Todo List

PhorumDBLayer

mysql.php

• phorum_api_user_check_access() is used in this layer, but the include file for that is not included here. Keep it like that or add the required include? Or is it functionality that doesn't belong here and could better go into the core maybe?

phorum_db_check_connection()

• we can save a function call by directly calling phorum_db_interact(). I'm also not sure if we need to do this check from common.php. We could take care of this in the db layer error handling too. Have to think about this ...

  Checks if a database connection can be made.

phorum_db_create_tables()

• It might be nice to have some feedback mechanism through a callback. Using that, table create status can be provided to the interface which is creating the tables. This is especially useful in case the create process fails at some point, in which case you currently have no good feedback about the create table progress.

phorum_db_file_save()

• Update docs, because it now is based on separate parameters, while the function itself requires an array now.

phorum_db_user_get_all()

• This function might be as well replaced with user search and get functionality from the user API, if search is extended with an option to return a resource handle.

phorum_db_user_get_list()

• This function might be as well replaced with user search and get functionality from the user API,

phorum_db_user_get_unapproved()

• This function might be as well replaced with user search and get functionality from the user API.

Documentation generated on Sat, 11 Jan 2014 01:45:59 -0600 by phpDocumentor 1.4.3